Mcs 1957 windows auto downloader #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCS Merge development to master
MCS - Merge Development into Master
MCS - Merge Dev to Master
phile-caci
requested review from
rartiss55,
ThomasSchellenbergNextCentury and
NDCACI
ThomasSchellenbergNextCentury
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
The auto-downloader worked for me on Windows and Linux.
All the unit tests now pass on Windows.
On Windows, all of my integration tests passed, except 108 (level1) and 107 (oracle). Both of these seemed like minor rounding errors, so I don't think we need to solve them immediately. I'll add a ticket to deal with it later though.
I'm still running the integration tests on Linux (I got my auto-downloader to work again -- yay), but if I run into any issues with them, they're probably not due to this PR.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds downlaod support for windows.
The windows addressables and unity exec are in
developmentonly atm. To test, inmachine_common_sense/_version.pychange the version to 'development'.To test:
You can then cache addressables:
Run integration:
You should see it download the
developversion of the unity executable (MCS-AI2-THOR-Unity-App-vdevelop-{linux || win64 || mac}.zip:). I've tested the auto downloader in windows and linux, but a second set of eyes would be good. Also, can someone make sure nothing is broken in MacOS.Thanks!